mtd: physmap_of: Drop unnecessary static

[Linux-MTD Mailing List]

Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=6c51a52eeb58befd2e9be2ed7ee2c4c04139b336
Commit:     6c51a52eeb58befd2e9be2ed7ee2c4c04139b336
Parent:     a63be500c6663a98cedda15c1bb380e9a34349e8
Author:     Julia Lawall <julia.lawall at lip6.fr>
AuthorDate: Thu May 4 22:10:47 2017 +0200
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Thu May 11 11:49:21 2017 -0700

    mtd: physmap_of: Drop unnecessary static
    
    Drop static on a local variable, when the variable is initialized before
    any use on every possible execution path through the function.  The static
    has no benefit, and dropping it reduces the code size.
    
    The semantic patch that fixes this problem is as follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @bad exists@
    position p;
    identifier x;
    type T;
    @@
    
    static T x at p;
    ...
    x = <+...x...+>
    
    @@
    identifier x;
    expression e;
    type T;
    position p != bad.p;
    @@
    
    -static
     T x at p;
     ... when != x
         when strict
    ?x = e;
    // </smpl>
    
    The change in code size is indicates by the following output from the size
    command.
    
    before:
       text    data     bss     dec     hex filename
        835      80       8     923     39b drivers/mtd/maps/physmap_of_gemini.o
    
    after:
       text    data     bss     dec     hex filename
        823      80       0     903     387 drivers/mtd/maps/physmap_of_gemini.o
    
    Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 drivers/mtd/maps/physmap_of_gemini.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/maps/physmap_of_gemini.c b/drivers/mtd/maps/physmap_of_gemini.c
index 9d371cd..05b286b 100644
--- a/drivers/mtd/maps/physmap_of_gemini.c
+++ b/drivers/mtd/maps/physmap_of_gemini.c
@@ -59,7 +59,7 @@ int of_flash_probe_gemini(struct platform_device *pdev,
 			  struct device_node *np,
 			  struct map_info *map)
 {
-	static struct regmap *rmap;
+	struct regmap *rmap;
 	struct device *dev = &pdev->dev;
 	u32 val;
 	int ret;