mtd: cfi_cmdset_0020: Drop unnecessary static

[Linux-MTD Mailing List]

Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=a63be500c6663a98cedda15c1bb380e9a34349e8
Commit:     a63be500c6663a98cedda15c1bb380e9a34349e8
Parent:     5dc17fa6fb7063c6bc8ea9f3183ec19ca68bbfd6
Author:     Julia Lawall <julia.lawall at lip6.fr>
AuthorDate: Thu May 4 22:10:46 2017 +0200
Committer:  Brian Norris <computersforpeace at gmail.com>
CommitDate: Thu May 11 11:49:20 2017 -0700

    mtd: cfi_cmdset_0020: Drop unnecessary static
    
    Drop static on a local variable, when the variable is initialized before
    any use on every possible execution path through the function.  The static
    has no benefit, and dropping it reduces the code size.
    
    The semantic patch that fixes this problem is as follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @bad exists@
    position p;
    identifier x;
    type T;
    @@
    
    static T x at p;
    ...
    x = <+...x...+>
    
    @@
    identifier x;
    expression e;
    type T;
    position p != bad.p;
    @@
    
    -static
     T x at p;
     ... when != x
         when strict
    ?x = e;
    // </smpl>
    
    The change in code size is indicates by the following output from the size
    command.
    
    before:
       text    data     bss     dec     hex filename
      16671      48      16   16735    415f drivers/mtd/chips/cfi_cmdset_0020.o
    
    after:
       text    data     bss     dec     hex filename
      16639      48       8   16695    4137 drivers/mtd/chips/cfi_cmdset_0020.o
    
    Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>
    Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 drivers/mtd/chips/cfi_cmdset_0020.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/chips/cfi_cmdset_0020.c b/drivers/mtd/chips/cfi_cmdset_0020.c
index 94d3eb4..7d34296 100644
--- a/drivers/mtd/chips/cfi_cmdset_0020.c
+++ b/drivers/mtd/chips/cfi_cmdset_0020.c
@@ -666,7 +666,7 @@ cfi_staa_writev(struct mtd_info *mtd, const struct kvec *vecs,
 	size_t	 totlen = 0, thislen;
 	int	 ret = 0;
 	size_t	 buflen = 0;
-	static char *buffer;
+	char *buffer;
 
 	if (!ECCBUF_SIZE) {
 		/* We should fall back to a general writev implementation.