mtd: spi-nor: remove WARN_ONCE() message in spi_nor_write()

[Linux-MTD Mailing List]

Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=bc0e151514d09cadb56e473a10c783e64e48ce0b
Commit:     bc0e151514d09cadb56e473a10c783e64e48ce0b
Parent:     32c90f1682a01ff9e1c2fa83c18a15e35f7563ce
Author:     Cyrille Pitchen <cyrille.pitchen at atmel.com>
AuthorDate: Tue Dec 6 18:14:24 2016 +0100
Committer:  Cyrille Pitchen <cyrille.pitchen at atmel.com>
CommitDate: Fri Feb 10 13:54:52 2017 +0100

    mtd: spi-nor: remove WARN_ONCE() message in spi_nor_write()
    
    This patch removes the WARN_ONCE() test in spi_nor_write().
    This macro triggers the display of a warning message almost every time we
    use a UBI file-system because a write operation is performed at offset 64,
    which is in the middle of the SPI NOR memory page. This is a valid
    operation for ubifs.
    
    Hence this warning is pretty annoying and useless so we just remove it.
    
    Signed-off-by: Cyrille Pitchen <cyrille.pitchen at atmel.com>
    Suggested-by: Richard Weinberger <richard at nod.at>
    Suggested-by: Andras Szemzo <szemzo.andras at gmail.com>
    Acked-by: Boris Brezillon <boris.brezillon at free-electrons.com>
---
 drivers/mtd/spi-nor/spi-nor.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 4e35917..8610765 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1263,9 +1263,6 @@ static int spi_nor_write(struct mtd_info *mtd, loff_t to, size_t len,
 
 			page_offset = do_div(aux, nor->page_size);
 		}
-		WARN_ONCE(page_offset,
-			  "Writing at offset %zu into a NOR page. Writing partial pages may decrease reliability and increase wear of NOR flash.",
-			  page_offset);
 		/* the size of data remaining on the first page */
 		page_remain = min_t(size_t,
 				    nor->page_size - page_offset, len - i);