[MTD] [NAND] move gen_nand's probe function to .devinit.text

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Fri Apr 3 05:59:02 EDT 2009


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=9d63287a461c269edb39941744f4ff22223cf349
Commit:     9d63287a461c269edb39941744f4ff22223cf349
Parent:     f0b1e5892478d5bd683ff01bd95dc7bfc87f8e42
Author:     Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
AuthorDate: Sat Mar 28 00:26:58 2009 +0100
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Fri Apr 3 10:38:05 2009 +0100

    [MTD] [NAND] move gen_nand's probe function to .devinit.text
    
    A pointer to plat_nand_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.
    
    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.
    
    Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
    Cc: Kay Sievers <kay.sievers at vrfy.org>
    Cc: Hamish Moffatt <hamish at cloud.net.au>
    Cc: David Brownell <dbrownell at users.sourceforge.net>
    Cc: Andrew Morton <akpm at linux-foundation.org>
    Cc: Li Zefan <lizf at cn.fujitsu.com>
    Cc: Vitaly Wool <vitalywool at gmail.com>
    Cc: Thomas Gleixner <tglx at linutronix.de>
    Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
 drivers/mtd/nand/plat_nand.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/nand/plat_nand.c b/drivers/mtd/nand/plat_nand.c
index 75f9f48..86e1d08 100644
--- a/drivers/mtd/nand/plat_nand.c
+++ b/drivers/mtd/nand/plat_nand.c
@@ -30,7 +30,7 @@ struct plat_nand_data {
 /*
  * Probe for the NAND device.
  */
-static int __init plat_nand_probe(struct platform_device *pdev)
+static int __devinit plat_nand_probe(struct platform_device *pdev)
 {
 	struct platform_nand_data *pdata = pdev->dev.platform_data;
 	struct plat_nand_data *data;



More information about the linux-mtd-cvs mailing list