[MTD] [MAPS] move sa1100 flash's probe function to .devinit.text

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Fri Apr 3 05:59:02 EDT 2009


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=f0b1e5892478d5bd683ff01bd95dc7bfc87f8e42
Commit:     f0b1e5892478d5bd683ff01bd95dc7bfc87f8e42
Parent:     2cf3a11494b15949835ff92a7af15f979ac37bbd
Author:     Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
AuthorDate: Sat Mar 28 00:27:03 2009 +0100
Committer:  David Woodhouse <David.Woodhouse at intel.com>
CommitDate: Fri Apr 3 10:37:18 2009 +0100

    [MTD] [MAPS] move sa1100 flash's probe function to .devinit.text
    
    A pointer to sa1100_mtd_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.
    
    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.
    
    Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
    Cc: Nicolas Pitre <nico at marvell.com>
    Cc: Russell King <rmk+kernel at arm.linux.org.uk>
    Cc: Andrew Morton <akpm at linux-foundation.org>
    Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
---
 drivers/mtd/maps/sa1100-flash.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/maps/sa1100-flash.c b/drivers/mtd/maps/sa1100-flash.c
index 6f6a0f6..1757ab0 100644
--- a/drivers/mtd/maps/sa1100-flash.c
+++ b/drivers/mtd/maps/sa1100-flash.c
@@ -351,7 +351,7 @@ sa1100_setup_mtd(struct platform_device *pdev, struct flash_platform_data *plat)
 
 static const char *part_probes[] = { "cmdlinepart", "RedBoot", NULL };
 
-static int __init sa1100_mtd_probe(struct platform_device *pdev)
+static int __devinit sa1100_mtd_probe(struct platform_device *pdev)
 {
 	struct flash_platform_data *plat = pdev->dev.platform_data;
 	struct mtd_partition *parts;



More information about the linux-mtd-cvs mailing list