[PATCH] PM / devfreq: mtk-cci: avoid redundant conditions
Chanwoo Choi
chanwoo at kernel.org
Sat Sep 6 18:34:16 PDT 2025
Hi,
Applied it.
Thanks.
On Wed, Sep 3, 2025 at 9:15 PM Liao Yuanhong <liaoyuanhong at vivo.com> wrote:
>
> While 'if (i <= 0) ... else if (i > 0) ...' is technically equivalent to
> 'if (i <= 0) ... else ...', the latter is vastly easier to read because
> it avoids writing out a condition that is unnecessary. Let's drop such
> unnecessary conditions.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong at vivo.com>
> ---
> drivers/devfreq/mtk-cci-devfreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/mtk-cci-devfreq.c b/drivers/devfreq/mtk-cci-devfreq.c
> index 22fe9e631f8a..693c59c8037a 100644
> --- a/drivers/devfreq/mtk-cci-devfreq.c
> +++ b/drivers/devfreq/mtk-cci-devfreq.c
> @@ -86,7 +86,7 @@ static int mtk_ccifreq_set_voltage(struct mtk_ccifreq_drv *drv, int new_voltage)
> soc_data->sram_max_volt);
> return ret;
> }
> - } else if (pre_voltage > new_voltage) {
> + } else {
> voltage = max(new_voltage,
> pre_vsram - soc_data->max_volt_shift);
> ret = regulator_set_voltage(drv->proc_reg, voltage,
> --
> 2.34.1
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
More information about the Linux-mediatek
mailing list