Aw: Re: [RFC v1 10/14] arm64: dts: mediatek: mt7988: add lvts node

[Frank Wunderlich]

> Gesendet: Mittwoch, 27. November 2024 um 14:34
> Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno at collabora.com>
> An: "Frank Wunderlich" <linux at fw-web.de>, "Rob Herring" <robh at kernel.org>, "Krzysztof Kozlowski" <krzk+dt at kernel.org>, "Conor Dooley" <conor+dt at kernel.org>, "Matthias Brugger" <matthias.bgg at gmail.com>
> CC: "Frank Wunderlich" <frank-w at public-files.de>, devicetree at vger.kernel.org, linux-kernel at vger.kernel.org, linux-arm-kernel at lists.infradead.org, linux-mediatek at lists.infradead.org
> Betreff: Re: [RFC v1 10/14] arm64: dts: mediatek: mt7988: add lvts node
>
> Il 29/10/24 11:39, Frank Wunderlich ha scritto:
> > From: Frank Wunderlich <frank-w at public-files.de>
> >
> > Add Low Voltage Thermal Sensor (LVTS) node for mt7988 SoC.
> >
> > Signed-off-by: Frank Wunderlich <frank-w at public-files.de>
>
> Please add the lvts_calibration nvmem entry in this commit instead.

and leaving the other (currently not linked) subnodes?

> Cheers,
> Angelo
>
> > ---
> >   arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 13 +++++++++++++
> >   1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> > index ed8ce1e6f68b..de9a9ff2edd8 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> > @@ -4,6 +4,7 @@
> >   #include <dt-bindings interrupt-controller="" arm-gic.h="">
> >   #include <dt-bindings phy="" phy.h="">
> >   #include <dt-bindings pinctrl="" mt65xx.h="">
> > +#include <dt-bindings reset="" mediatek,mt7988-resets.h="">
> >
> >   / {
> >   	compatible = "mediatek,mt7988a";
> > @@ -103,6 +104,7 @@ infracfg: clock-controller at 10001000 {
> >   			compatible = "mediatek,mt7988-infracfg", "syscon";
> >   			reg = <0 0x10001000 0 0x1000>;
> >   			#clock-cells = <1>;
> > +			#reset-cells = <1>;
> >   		};
> >
> >   		topckgen: clock-controller at 1001b000 {
> > @@ -268,6 +270,17 @@ i2c2: i2c at 11005000 {
> >   			status = "disabled";
> >   		};
> >
> > +		lvts: lvts at 1100a000 {
> > +			compatible = "mediatek,mt7988-lvts-ap";
> > +			#thermal-sensor-cells = <1>;
> > +			reg = <0 0x1100a000 0 0x1000>;
> > +			clocks = <&infracfg CLK_INFRA_26M_THERM_SYSTEM>;
> > +			interrupts = <gic_spi 138="" irq_type_level_high="">;
> > +			resets = <&infracfg MT7988_INFRA_RST1_THERM_CTRL_SWRST>;
> > +			nvmem-cells = <&lvts_calibration>;
> > +			nvmem-cell-names = "lvts-calib-data-1";
> > +		};
> > +
> >   		ssusb0: usb at 11190000 {
> >   			compatible = "mediatek,mt7988-xhci", "mediatek,mtk-xhci";
> >   			reg = <0 0x11190000 0 0x2e00>,
>
> </gic_spi></dt-bindings></dt-bindings></dt-bindings></dt-bindings></frank-w at public-files.de></frank-w at public-files.de></frank-w at public-files.de></matthias.bgg at gmail.com></conor+dt at kernel.org></krzk+dt at kernel.org></robh at kernel.org></linux at fw-web.de></angelogioacchino.delregno at collabora.com>