[PATCH net v3] net: dsa: mt7530: fix impossible MDIO address and issue warning

[Arınç ÜNAL]

On 04/07/2024 20:21, Vladimir Oltean wrote:
> On Wed, Jul 03, 2024 at 10:03:09AM +0300, Arınç ÜNAL wrote:
>> Works on standalone MT7530, MT7621's MCM MT7530, and MT7531. From MT7621's
>> MCM MT7530:
>>
>> [    1.357287] mt7530-mdio mdio-bus:1f: MT7530 adapts as multi-chip module
> 
> Why is the device corresponding to the first print located at address 1f,
> then 0?

Because mdio_device_register() in mt7530_reregister() runs with new_mdiodev
after dev_warn() runs with mdiodev.

> 
>> [    1.364065] mt7530-mdio mdio-bus:00: [Firmware Warn]: impossible switch MDIO address in device tree, assuming 31
>> [    1.374303] mt7530-mdio mdio-bus:00: probe with driver mt7530-mdio failed with error -14
>> [...]
>> [    1.448370] mt7530-mdio mdio-bus:1f: MT7530 adapts as multi-chip module
>> [    1.477676] mt7530-mdio mdio-bus:1f: configuring for fixed/rgmii link mode
>> [    1.485687] mt7530-mdio mdio-bus:1f: Link is Up - 1Gbps/Full - flow control rx/tx
>> [    1.493480] mt7530-mdio mdio-bus:1f: configuring for fixed/trgmii link mode
>> [    1.502680] mt7530-mdio mdio-bus:1f lan1 (uninitialized): PHY [mt7530-0:00] driver [MediaTek MT7530 PHY] (irq=17)
>> [    1.513620] mt7530-mdio mdio-bus:1f: Link is Up - 1Gbps/Full - flow control rx/tx
>> [    1.519671] mt7530-mdio mdio-bus:1f lan2 (uninitialized): PHY [mt7530-0:01] driver [MediaTek MT7530 PHY] (irq=18)
>> [    1.533072] mt7530-mdio mdio-bus:1f lan3 (uninitialized): PHY [mt7530-0:02] driver [MediaTek MT7530 PHY] (irq=19)
>> [    1.545042] mt7530-mdio mdio-bus:1f lan4 (uninitialized): PHY [mt7530-0:03] driver [MediaTek MT7530 PHY] (irq=20)
>> [    1.557031] mt7530-mdio mdio-bus:1f wan (uninitialized): PHY [mt7530-0:04] driver [MediaTek MT7530 PHY] (irq=21)

Arınç