[PATCH v2 1/5] pinctrl: mediatek: add generic driving setup property on mt8192

Guodong Liu guodong.liu at mediatek.com
Sat Jun 25 21:45:41 PDT 2022


-----Original Message-----
From: Nícolas F. R. A. Prado <nfraprado at collabora.com>
To: Guodong Liu <guodong.liu at mediatek.com>
Cc: Linus Walleij <linus.walleij at linaro.org>, Rob Herring <
robh+dt at kernel.org>, Matthias Brugger <matthias.bgg at gmail.com>, Sean
Wang <sean.wang at kernel.org>, Sean Wang <sean.wang at mediatek.com>,
Zhiyong Tao <zhiyong.tao at mediatek.com>, linux-gpio at vger.kernel.org, 
devicetree at vger.kernel.org, linux-arm-kernel at lists.infradead.org, 
linux-mediatek at lists.infradead.org, linux-kernel at vger.kernel.org, 
Project_Global_Chrome_Upstream_Group at mediatek.com
Subject: Re: [PATCH v2 1/5] pinctrl: mediatek: add generic driving
setup property on mt8192
Date: Fri, 24 Jun 2022 11:52:24 -0400

Hi Guodong,

please see comments below.

On Fri, Jun 24, 2022 at 09:36:56PM +0800, Guodong Liu wrote:
> 1. The dt-binding expects that drive-strength arguments be passed
> in mA, but the driver was expecting raw values. And that this
> commit changes the driver so that it is aligned with the binding.
> 2. This commit provides generic driving setup, which support
> 2/4/6/8/10/12/14/16mA driving, original driver just set raw data
> setup setting when use drive-strength property.

This commit message is a bit confusing, I suggest using the following
commit
message instead:

The dt-binding expects the drive-strength arguments to be passed in mA,
but the
driver was using callbacks that expect raw values instead. Change the
callbacks
for the ones that operate on mA values, so that the driver is in
accordance to
the dt-binding.

The drive-strength property requiring values in mA is the standard and
other
MediaTek SoCs of the same generation already do the same, so this
change avoids
mt8192 having a non-standard property.

There are no current upstream users of this driver, so this change
doesn't cause
any regression.

Fixed in next patch, thanks!

> 
> Signed-off-by: Guodong Liu <guodong.liu at mediatek.com>

Reviewed-by: Nícolas F. R. A. Prado <nfraprado at collabora.com>
Tested-by: Nícolas F. R. A. Prado <nfraprado at collabora.com>

Thanks,
Nícolas


More information about the Linux-mediatek mailing list