[PATCH v11 2/4] dt-bindings: pinctrl: mt8195: change pull up/down description
zhiyong.tao
zhiyong.tao at mediatek.com
Tue Aug 31 19:00:36 PDT 2021
On Tue, 2021-08-31 at 17:13 -0500, Rob Herring wrote:
> On Mon, Aug 30, 2021 at 08:36:01AM +0800, Zhiyong Tao wrote:
> > Change pull up/down description
>
> Every commit is a 'change'. Your commit msg should explain 'why', not
> what the diff is.
>
Hi robh,
we will add 'why' explanation in the commit msg in v12.
> >
> > Signed-off-by: Zhiyong Tao <zhiyong.tao at mediatek.com>
> > ---
> > .../bindings/pinctrl/pinctrl-mt8195.yaml | 32 +++++++++++++++++--
> > 1 file changed, 29 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> > index 2f12ec59eee5..a341ed9f0095 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> > @@ -85,9 +85,35 @@ patternProperties:
> > 2/4/6/8/10/12/14/16mA in mt8195.
> > enum: [0, 1, 2, 3, 4, 5, 6, 7]
> >
> > - bias-pull-down: true
> > -
> > - bias-pull-up: true
> > + bias-pull-down:
> > + description: |
> > + For pull down type is normal, it don't need add RSEL & R1R0 define
> > + and resistance value.
> > + For pull down type is PUPD/R0/R1 type, it can add R1R0 define to
> > + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" &
> > + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11"
> > + define in mt8195.
> > + For pull down type is RSEL, it can add RSEL define & resistance value(ohm)
> > + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" &
> > + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" &
> > + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" &
> > + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm)
> > + "75000" & "5000" in mt8195.
>
> Sounds like constraints on the values. Please write a schema.
>
we will add a schema here in v12.
Thanks
> > +
> > + bias-pull-up:
> > + description: |
> > + For pull up type is normal, it don't need add RSEL & R1R0 define
> > + and resistance value.
> > + For pull up type is PUPD/R0/R1 type, it can add R1R0 define to
> > + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" &
> > + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11"
> > + define in mt8195.
> > + For pull up type is RSEL, it can add RSEL define & resistance value(ohm)
> > + to set different resistance. It can support "MTK_PULL_SET_RSEL_000" &
> > + "MTK_PULL_SET_RSEL_001" & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" &
> > + "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" &
> > + "MTK_PULL_SET_RSEL_111" define in mt8195. It can also support resistance value(ohm)
> > + "1000" & "1500" & "2000" & "3000" & "4000" & "5000" & "10000" & "75000" in mt8195.
> >
> > bias-disable: true
> >
> > --
> > 2.18.0
> >
> >
More information about the Linux-mediatek
mailing list