[PATCH net-next v2 2/3] net: ethernet: mediatek: get hw lro capability by the chip id instead of by the dtsi
Nelson Chang
nelson.chang at mediatek.com
Wed Oct 5 06:21:47 PDT 2016
Hi Sergei, David,
I think modifying that as below is clear and scalable. Agree?
static bool mtk_is_hwlro_supported(struct mtk_eth *eth)
{
switch (eth->chip_id) {
case MT7623_ETH:
return true;
}
return false;
}
Thanks.
Nelson
-----Original Message-----
From: David Laight [mailto:David.Laight at ACULAB.COM]
Sent: Wednesday, October 05, 2016 9:07 PM
To: Nelson Chang (張家祥); sergei.shtylyov at cogentembedded.com;
john at phrozen.org; davem at davemloft.net
Cc: nbd at openwrt.org; netdev at vger.kernel.org;
linux-mediatek at lists.infradead.org; nelsonch.tw at gmail.com
Subject: RE: [PATCH net-next v2 2/3] net: ethernet: mediatek: get hw lro
capability by the chip id instead of by the dtsi
From: Nelson Chang
> Sent: 05 October 2016 13:46
> > +static bool mtk_is_hwlro_supported(struct mtk_eth *eth) {
> > + if (eth->chip_id == MT7623_ETH)
> > + return true;
> > + else
> > + return false;
>
> return eth->chip_id == MT7623_ETH;
>
> => Since there will be more chips support hw lro in the future, keep
> the original codes to have the scalability like this:
> if (eth->chip_id == MTxxxx_ETH ||
> eth->chip_id == MTyyyy_ETH ||
> ....)
> return true;
Nothing wrong with:
return eth->chip_id == MTxxxx_ETH ||
eth->chip_id == MTyyyy_ETH;
David
More information about the Linux-mediatek
mailing list