[PATCH net-next v2 2/3] net: ethernet: mediatek: get hw lro capability by the chip id instead of by the dtsi
David Laight
David.Laight at ACULAB.COM
Wed Oct 5 06:07:11 PDT 2016
From: Nelson Chang
> Sent: 05 October 2016 13:46
> > +static bool mtk_is_hwlro_supported(struct mtk_eth *eth) {
> > + if (eth->chip_id == MT7623_ETH)
> > + return true;
> > + else
> > + return false;
>
> return eth->chip_id == MT7623_ETH;
>
> => Since there will be more chips support hw lro in the future, keep the
> original codes to have the scalability like this:
> if (eth->chip_id == MTxxxx_ETH ||
> eth->chip_id == MTyyyy_ETH ||
> ....)
> return true;
Nothing wrong with:
return eth->chip_id == MTxxxx_ETH ||
eth->chip_id == MTyyyy_ETH;
David
More information about the Linux-mediatek
mailing list