[PATCH V3 08/11] soc: mediatek: PMIC wrap: remove pwrap_is_mt8135() and pwrap_is_mt8173()

[John Crispin]

On 01/02/2016 11:55, Matthias Brugger wrote:
> 
> 
> On 25/01/16 10:53, John Crispin wrote:
>> With ore SoCs being added the list of helper functions like these would
> 
> The commit message is something strange:
> "With every new SoC being added..." maybe?
> 
>> grow. While at it also add a new flag "bridge" and use that insted of
> 
> s/insted/instead
> 
>> pwrap_is_mt8173() where appropriate.

you are lookign at V3 of the series, V4 has this fix done already

[...]


>>       }
>> @@ -830,6 +824,7 @@ static struct pmic_wrapper_type pwrap_mt8135 = {
>>       .int_en_all = BIT(31) | BIT(1),
>>       .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
>>       .wdt_src = PWRAP_WDT_SRC_MASK_ALL,
>> +    .has_bridge = 1,
>>       .init_reg_clock = pwrap_mt8135_init_reg_clock,
>>       .init_special = pwrap_mt8135_init_special,
>>   };
> 
> Please set has_bridge explicitly for mt8173.

I dont get it. the original code never did that.

	John

> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek