[PATCH v2 2/4] i3c: master: svc: Add basic HDR mode support

Miquel Raynal miquel.raynal at bootlin.com
Mon Sep 29 09:04:46 PDT 2025


On 29/09/2025 at 11:55:31 -04, Frank Li <Frank.li at nxp.com> wrote:

> On Mon, Sep 29, 2025 at 05:38:03PM +0200, Miquel Raynal wrote:
>> Hi Frank,
>>
> ...
>
>> > @@ -1858,7 +1913,7 @@ static const struct i3c_master_controller_ops svc_i3c_master_ops = {
>> >  	.do_daa = svc_i3c_master_do_daa,
>> >  	.supports_ccc_cmd = svc_i3c_master_supports_ccc_cmd,
>> >  	.send_ccc_cmd = svc_i3c_master_send_ccc_cmd,
>> > -	.priv_xfers = svc_i3c_master_priv_xfers,
>> > +	.i3c_xfers = svc_i3c_master_i3c_xfers,
>>
>> Didn't you change this name in patch 1? If you kept both naming, it's
>> fine, otherwise you must do the switch in patch 1 as well to make sure
>> you don't break the build in the middle of the series.
>
> We keep both API for while. After first patch apply, I change all drivers
> to i3c_xfers, then remove old .priv_xfers.

Fine. Maybe mark it deprecated with a comment in the core? (I haven't
checked).



More information about the linux-i3c mailing list