[PATCH v2 2/4] i3c: master: svc: Add basic HDR mode support

Frank Li Frank.li at nxp.com
Mon Sep 29 08:55:31 PDT 2025


On Mon, Sep 29, 2025 at 05:38:03PM +0200, Miquel Raynal wrote:
> Hi Frank,
>
...

> > @@ -1858,7 +1913,7 @@ static const struct i3c_master_controller_ops svc_i3c_master_ops = {
> >  	.do_daa = svc_i3c_master_do_daa,
> >  	.supports_ccc_cmd = svc_i3c_master_supports_ccc_cmd,
> >  	.send_ccc_cmd = svc_i3c_master_send_ccc_cmd,
> > -	.priv_xfers = svc_i3c_master_priv_xfers,
> > +	.i3c_xfers = svc_i3c_master_i3c_xfers,
>
> Didn't you change this name in patch 1? If you kept both naming, it's
> fine, otherwise you must do the switch in patch 1 as well to make sure
> you don't break the build in the middle of the series.

We keep both API for while. After first patch apply, I change all drivers
to i3c_xfers, then remove old .priv_xfers.

Frank

>
> >  	.i2c_xfers = svc_i3c_master_i2c_xfers,
> >  	.request_ibi = svc_i3c_master_request_ibi,
> >  	.free_ibi = svc_i3c_master_free_ibi,
> > @@ -1947,6 +2002,8 @@ static int svc_i3c_master_probe(struct platform_device *pdev)
> >
> >  	svc_i3c_master_reset(master);
> >
> > +	master->base.mode_mask = BIT(I3C_SDR) | BIT(I3C_HDR_DDR);
> > +
> >  	/* Register the master */
> >  	ret = i3c_master_register(&master->base, &pdev->dev,
> >  				  &svc_i3c_master_ops, false);
>
> Thanks,
> Miquèl



More information about the linux-i3c mailing list