[PATCH V4 06/12] i3c: mipi-i3c-hci-pci: Factor out private registers ioremapping

[Frank Li]

On Tue, Nov 18, 2025 at 06:44:47PM +0200, Adrian Hunter wrote:
> For neatness, factor out private registers ioremapping.
>
> Signed-off-by: Adrian Hunter <adrian.hunter at intel.com>
> ---

Reviewed-by: Frank Li <Frank.Li at nxp.com>

>
>
> Changes in V3 and V4:
>
> 	None
>
> Changes in V2:
>
> 	Re-based
>
>
>  drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> index abc7bad5e069..1e1f2c42bd74 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> @@ -27,14 +27,18 @@ static DEFINE_IDA(mipi_i3c_hci_pci_ida);
>  #define INTEL_RESETS_RESET_DONE		BIT(1)
>  #define INTEL_RESETS_TIMEOUT_US		(10 * USEC_PER_MSEC)
>
> +static void __iomem *intel_priv(struct pci_dev *pci)
> +{
> +	resource_size_t base = pci_resource_start(pci, 0);
> +
> +	return devm_ioremap(&pci->dev, base + INTEL_PRIV_OFFSET, INTEL_PRIV_SIZE);
> +}
> +
>  static int intel_i3c_init(struct pci_dev *pci)
>  {
> -	void __iomem *priv;
> +	void __iomem *priv = intel_priv(pci);
>  	u32 reg;
>
> -	priv = devm_ioremap(&pci->dev,
> -			    pci_resource_start(pci, 0) + INTEL_PRIV_OFFSET,
> -			    INTEL_PRIV_SIZE);
>  	if (!priv)
>  		return -ENOMEM;
>
> --
> 2.51.0
>
>
> --
> linux-i3c mailing list
> linux-i3c at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c