[PATCH V4 07/12] i3c: mipi-i3c-hci-pci: Factor out intel_reset()
Adrian Hunter
adrian.hunter at intel.com
Tue Nov 18 08:44:48 PST 2025
For neatness, factor out intel_reset().
Signed-off-by: Adrian Hunter <adrian.hunter at intel.com>
Reviewed-by: Frank Li <Frank.Li at nxp.com>
---
Changes in V4:
None
Changes in V3:
Add Frank's Rev'd-by
Changes in V2:
Move location of intel_reset() to get a prettier diff
.../master/mipi-i3c-hci/mipi-i3c-hci-pci.c | 20 ++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
index 1e1f2c42bd74..b9794212b2fb 100644
--- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
+++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
@@ -27,6 +27,18 @@ static DEFINE_IDA(mipi_i3c_hci_pci_ida);
#define INTEL_RESETS_RESET_DONE BIT(1)
#define INTEL_RESETS_TIMEOUT_US (10 * USEC_PER_MSEC)
+static void intel_reset(void __iomem *priv)
+{
+ u32 reg;
+
+ /* Assert reset, wait for completion and release reset */
+ writel(0, priv + INTEL_RESETS);
+ readl_poll_timeout(priv + INTEL_RESETS, reg,
+ reg & INTEL_RESETS_RESET_DONE, 0,
+ INTEL_RESETS_TIMEOUT_US);
+ writel(INTEL_RESETS_RESET, priv + INTEL_RESETS);
+}
+
static void __iomem *intel_priv(struct pci_dev *pci)
{
resource_size_t base = pci_resource_start(pci, 0);
@@ -37,19 +49,13 @@ static void __iomem *intel_priv(struct pci_dev *pci)
static int intel_i3c_init(struct pci_dev *pci)
{
void __iomem *priv = intel_priv(pci);
- u32 reg;
if (!priv)
return -ENOMEM;
dma_set_mask_and_coherent(&pci->dev, DMA_BIT_MASK(64));
- /* Assert reset, wait for completion and release reset */
- writel(0, priv + INTEL_RESETS);
- readl_poll_timeout(priv + INTEL_RESETS, reg,
- reg & INTEL_RESETS_RESET_DONE, 0,
- INTEL_RESETS_TIMEOUT_US);
- writel(INTEL_RESETS_RESET, priv + INTEL_RESETS);
+ intel_reset(priv);
return 0;
}
--
2.51.0
More information about the linux-i3c
mailing list