[PATCH v3 1/3] i3c: master: Add inline i3c_readl_fifo() and i3c_writel_fifo()

Wolfram Sang wsa+renesas at sang-engineering.com
Wed Jun 25 00:24:37 PDT 2025


On Tue, Jun 24, 2025 at 11:06:04AM +0200, Jorge Marques wrote:
> The I3C abstraction expects u8 buffers, but some controllers operate with
> a 32-bit bus width FIFO and cannot flag valid bytes individually. To avoid
> reading or writing outside the buffer bounds, use 32-bit accesses where
> possible and apply memcpy for any remaining bytes
> 
> Signed-off-by: Jorge Marques <jorge.marques at analog.com>

As per [1]:
Suggested-by: Wolfram Sang <wsa+renesas at sang-engineering.com>

My concern is rejected, and the rest looks good to me, so:
Reviewed-by: Wolfram Sang <wsa+renesas at sang-engineering.com>

It still works nicely with the Renesas driver:
Tested-by: Wolfram Sang <wsa+renesas at sang-engineering.com>

[1] https://lore.kernel.org/r/20250611093934.4208-5-wsa+renesas@sang-engineering.com



More information about the linux-i3c mailing list