[PATCH v3 1/3] i3c: master: Add inline i3c_readl_fifo() and i3c_writel_fifo()
Wolfram Sang
wsa+renesas at sang-engineering.com
Wed Jun 25 00:20:50 PDT 2025
> > Is there a reason we don't put this in 'include/linux/i3c/master.h'?
>
> master.h can be accessed in whole kernel tree. The scope is too big for these
> helper functions, which should only limited to i3c drivers.
Yet, who is going to include 'linux/i3c/master.h' outside of an I3C
controller driver?
>
> > 'internals.h' is used for the core only so far, and '#include
> > <../something.h>' also looks a bit like a layering violation.
>
> Not yet, you can look driver/pci/controller/*, which include ../pci.h.
I never denied that it already exists in the kernel. But it still looks
fragile to me.
Whatever, it's not worth a big discussion. We can move this code if
there ever comes a reason to do so.
More information about the linux-i3c
mailing list