[PATCH v3 5/5] i3c: mipi-i3c-hci: Move unexpected INTR_STATUS print before IO handler
Jarkko Nikula
jarkko.nikula at linux.intel.com
Wed Apr 9 07:04:01 PDT 2025
Move "unexpected INTR_STATUS" error print before calling the IO handler
as it is more consistent that way. Otherwise it may be confusing if
generic interrupt related prints are mixed with IO handler prints.
Since this error print is more indication of missing code rather than
runtime error downgrade it to dev_warn_once().
Reviewed-by: Frank Li <Frank.Li at nxp.com>
Signed-off-by: Jarkko Nikula <jarkko.nikula at linux.intel.com>
---
v2: Added Reviewed-by
---
drivers/i3c/master/mipi-i3c-hci/core.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
index 0bb74173ca94..bc4538694540 100644
--- a/drivers/i3c/master/mipi-i3c-hci/core.c
+++ b/drivers/i3c/master/mipi-i3c-hci/core.c
@@ -606,12 +606,13 @@ static irqreturn_t i3c_hci_irq_handler(int irq, void *dev_id)
val &= ~INTR_HC_INTERNAL_ERR;
}
+ if (val)
+ dev_warn_once(&hci->master.dev,
+ "unexpected INTR_STATUS %#x\n", val);
+
if (hci->io->irq_handler(hci))
result = IRQ_HANDLED;
- if (val)
- dev_err(&hci->master.dev, "unexpected INTR_STATUS %#x\n", val);
-
return result;
}
--
2.47.2
More information about the linux-i3c
mailing list