[PATCH v3 02/11] i3c: master: Replace hard code 2 with macro I3C_ADDR_SLOT_BITS

Miquel Raynal miquel.raynal at bootlin.com
Fri Aug 23 08:55:02 PDT 2024


Hi Frank,

Frank.Li at nxp.com wrote on Mon, 19 Aug 2024 12:01:56 -0400:

> Replace the hardcoded value 2, which indicates 2 bits for I3C address
> status, with the predefined macro I3C_ADDR_SLOT_BITS.

I'm fine with the idea but I don't understand the macro name. You're
talking about status bits and yet the macro is named addr_slot?

> Improve maintainability and extensibility of the code.

Thanks,
Miquèl



More information about the linux-i3c mailing list