[PATCH v4 1/6] i3c: mipi-i3c-hci: Add AMDI5017 ACPI ID to the I3C Support List

[Shyam Sundar S K]

On 8/21/2024 21:09, Andy Shevchenko wrote:
> On Wed, Aug 21, 2024 at 08:42:12PM +0530, Shyam Sundar S K wrote:
>> On 8/21/2024 19:26, Andy Shevchenko wrote:
>>> On Wed, Aug 21, 2024 at 07:07:45PM +0530, Shyam Sundar S K wrote:
>>>> On 8/21/2024 19:05, Shyam Sundar S K wrote:
> 
> ...
> 
>>>>> This update adds the AMDI5017 ACPI ID to the list of supported IDs.
> 
> s/This update adds/Add/
> 
>>> Please, provide a DSDT excerpt to show how it will look like in the ACPI
>>> tables.
>>
>>     Scope (_SB)
>>     {
>> 	...
>>
>>         Name (HCID, "AMDI5017")
>>         Device (I3CA)
>>         {
>>             Method (_HID, 0, Serialized)  // _HID: Hardware ID
>>             {
>>                 If ((I30M == Zero))
>>                 {
>>                     If (CondRefOf (HCIB))
>>                     {
>>                         Return (HCID) /* \_SB_.HCID */
>>                     }
>>                     Else
>>                     {
>>                         Return (I3ID) /* \_SB_.I3ID */
> 
> Do I understand correctly that I3ID is the old one (as per another path I have
> seen last week or so), i.o.w. *not* a MIPI allocated one?

Yes. That's right.

> 
> If it's the case, feel free to add
> Reviewed-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> from ACPI ID perspective.
> 
>>                     }
>>                 }
>>                 Else
>>                 {
>>                     Return (I2ID) /* \_SB_.I2ID */
>>                 }
>>             }
>> 	
>> 	...
>>     }
>