[PATCH v2 1/3] dmaengine: vchan: add vchan_chan_name() to get channel device name
Amelie Delaunay
amelie.delaunay at foss.st.com
Fri Sep 4 02:26:37 PDT 2026
On 9/4/26 11:08, Andy Shevchenko wrote:
> On Thu, Sep 03, 2026 at 04:53:11PM -0400, Frank.Li at oss.nxp.com wrote:
>
>> Introduce vchan_chan_name() to obtain the DMA channel device name.
>>
>> Use a dedicated helper instead of directly accessing dma_chan::dev
>> so callers remain unaffected by an upcoming rename of the struct member.
>
> LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
>
> ...
>
>> ret = devm_request_irq(&pdev->dev, chan->irq,
>> stm32_dma_chan_irq, 0,
>> - dev_name(chan2dev(chan)), chan);
>> + vchan_chan_name(&chan->vchan), chan);
>> if (ret) {
>> dev_err(&pdev->dev,
>> "request_irq failed with err %d channel %d\n",
>
> This one...
>
>> +++ b/drivers/dma/stm32/stm32-dma3.c
>
>> ret = devm_request_irq(&pdev->dev, chan->irq, stm32_dma3_chan_irq, 0,
>> - dev_name(chan2dev(chan)), chan);
>> + vchan_chan_name(&chan->vchan), chan);
>> if (ret) {
>> dev_err_probe(&pdev->dev, ret, "Failed to request channel %s IRQ\n",
>> - dev_name(chan2dev(chan)));
>> + vchan_chan_name(&chan->vchan));
>> goto err_clk_disable;
>
> ...and this one are duplicate messages as devm_request*irq() printsr
> most of the information.
>
> Not sure if there will be a patch to simply drop them.
>
It was the purpose of this series:
https://lore.kernel.org/dmaengine/20260709135846.97972-1-panchuang@vivo.com/
More information about the linux-arm-kernel
mailing list