[PATCH 4/5] pwm: cadence: Add TTC PWM driver
Vanukuri, Meher Thanmaiee
MeherThanmaiee.Vanukuri at amd.com
Thu Oct 15 05:28:34 PDT 2026
Hi Uwe,
On 10/7/2026 5:11 PM, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Oct 07, 2026 at 02:37:02PM +0530, Meher Thanmaiee wrote:
>> +static const struct pwm_ops cdns_ttc_pwm_ops = {
>> + .apply = cdns_ttc_pwm_apply,
>> + .get_state = cdns_ttc_pwm_get_state,
>> +};
>
> Just a very quick review: I won't take any new drivers using .apply().
> Please use the waveform stuff. And also note that there is Rust support
> for PWMs, so if you're adventurous try that. (The reference in that case
> would be drivers/pwm/pwm_th1520.rs.)
Thanks for the review. I will rework the driver to use the waveform API
and send an updated patch series.
>
> Best regards
> Uwe
Regards,
Meher
More information about the linux-arm-kernel
mailing list