[PATCH 4/5] pwm: cadence: Add TTC PWM driver
Uwe Kleine-König
ukleinek at kernel.org
Wed Oct 7 04:41:46 PDT 2026
Hello,
On Wed, Oct 07, 2026 at 02:37:02PM +0530, Meher Thanmaiee wrote:
> +static const struct pwm_ops cdns_ttc_pwm_ops = {
> + .apply = cdns_ttc_pwm_apply,
> + .get_state = cdns_ttc_pwm_get_state,
> +};
Just a very quick review: I won't take any new drivers using .apply().
Please use the waveform stuff. And also note that there is Rust support
for PWMs, so if you're adventurous try that. (The reference in that case
would be drivers/pwm/pwm_th1520.rs.)
Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20261007/541fab17/attachment.sig>
More information about the linux-arm-kernel
mailing list