[PATCH 1/3] dt-bindings: iio: adc: add bindings for stm32 mdf filter

Olivier MOYSAN olivier.moysan at foss.st.com
Tue Oct 6 09:04:01 PDT 2026


Hi Krzysztof,

On 10/2/26 11:34, Krzysztof Kozlowski wrote:
> On Thu, Oct 01, 2026 at 04:56:45PM +0200, Olivier Moysan wrote:
>> +  clock-output-names:
>> +    description: |
>> +      CCK0 and CCK1 are optional output clocks, which share the same clock frequency,
>> +      but can be gated independently to save power.
>> +    minItems: 1
>> +    maxItems: 2
>> +    oneOf:
>> +      - items:
>> +          - const: cck0
>> +      - items:
>> +          - const: cck1
>> +      - items:
>> +          - const: cck0
>> +          - const: cck1
> 
> Use simpler notation:
> minItems: 1
> items:
>    - enum
>    - const
> 
>> +
>> +  clock-frequency:
>> +    description: |
> 
> Drop | when not needed.
> 
>> +      Common clock frequency (Hz) for CCK0 and CCK1 output clocks.
>> +      The frequency must be a multiple of the "ker_ck" clock frequency.
>> +    maximum: 25000000
> 
> So here is the clock-frequency. No, these are output clocks as written
> above, so consumer sets it, not the provider. Or use existing assigned
> properties. This is even mentioned on DTS101 slides, really...
> 

We expect the clock frequency to be defined statically for a given board 
So, using assigned-clocks properties looks the right choice.
What bothers me about this solution, is that the frequency will be 
defined in each consumer, whereas a single rate can be defined for the 
provider. This may looks a bit strange, but I will implement it this way 
if there is no other mean to set the provider frequency.


> Best regards,
> Krzysztof
> 

Best regards
Olivier



More information about the linux-arm-kernel mailing list