[PATCH net-next v2 00/15] net: stmmac: qcom-ethqos: more cleanups
Russell King (Oracle)
linux at armlinux.org.uk
Fri Mar 27 01:42:58 PDT 2026
Further cleanups to qcom-ethqos, mainly concentrating on the RGMII
code, making it clearer what the differences are for each speed, thus
making the code more readable.
I'm still not really happy with this. The speed specific configuration
remains split between ethqos_fix_mac_speed_rgmii() and
ethqos_rgmii_macro_init(), where the latter is only ever called from
the former. So, I think further work is needed here - maybe it needs
restructuring into the various componenet parts of the RGMII block?
v2:
- patch 2: fix typo in commit message
- patch 3: fix ethqos_fix_mac_speed() comment
.../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 220 ++++++++-------------
1 file changed, 87 insertions(+), 133 deletions(-)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
More information about the linux-arm-kernel
mailing list