[PATCH 1/2] dt-bindings: phy: nuvoton: Add MA35D1 USB2 OTG PHY binding
Krzysztof Kozlowski
krzk at kernel.org
Mon Jun 8 03:45:51 PDT 2026
On Thu, Jun 04, 2026 at 06:12:19PM +0800, Joey Lu wrote:
A nit, subject: drop second/last, redundant "binding". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> +properties:
> + compatible:
> + const: nuvoton,ma35d1-usb2-phy-otg
> +
Where is reg? MMIO is expressed with reg, not via custom phandle.
> + clocks:
> + maxItems: 1
> +
> + nuvoton,sys:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + - items:
> + - description: phandle to the system management syscon.
> + - description: PHY instance index.
> + enum:
> + - 0 # USB0, OTG port (shared with DWC2 gadget controller)
> + - 1 # USB1, host-only port
> + description:
> + A phandle to the syscon node covering the SYS register block, with
> + one argument selecting the PHY instance. Index 0 selects the OTG
> + port PHY (USB0) and index 1 selects the host-only PHY (USB1).
> +
> + "#phy-cells":
> + const: 0
> +
> + nuvoton,rcalcode:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0
> + maximum: 15
> + description:
> + Resistor calibration trim code written to the RCALCODE field in
> + USBPMISCR. The 4-bit value adjusts the PHY's internal termination
> + resistance. When absent the hardware reset default is used.
> +
> + nuvoton,oc-active-high:
> + type: boolean
> + description:
> + When present, the over-current detect input from the VBUS power
> + switch is treated as active-high. The default (property absent) is
> + active-low. This setting is shared by both USB host ports.
> +
> +required:
> + - compatible
> + - clocks
> + - nuvoton,sys
> + - "#phy-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/nuvoton,ma35d1-clk.h>
> +
> + usb_hphy0: usb-host-phy {
usb-phy
And drop unused label.
> + compatible = "nuvoton,ma35d1-usb2-phy-otg";
> + clocks = <&clk HUSBH0_GATE>;
> + nuvoton,sys = <&sys 0>;
> + #phy-cells = <0>;
> + };
> --
> 2.43.0
>
More information about the linux-arm-kernel
mailing list