[PATCH] spi: xilinx: use device property accessors.
Michal Simek
michal.simek at amd.com
Thu Jan 15 23:51:00 PST 2026
On 1/15/26 01:33, Abdurrahman Hussain wrote:
> This makes the driver work on non-OF platforms.
> Also, make irq optional, since the driver can already work in
> polling mode.
>
> Signed-off-by: Abdurrahman Hussain <abdurrahman at nexthop.ai>
> ---
> drivers/spi/spi-xilinx.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index c86dc56f38b4..9fb1da2fcce4 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -405,11 +405,11 @@ static int xilinx_spi_probe(struct platform_device *pdev)
> bits_per_word = pdata->bits_per_word;
> force_irq = pdata->force_irq;
> } else {
> - of_property_read_u32(pdev->dev.of_node, "xlnx,num-ss-bits",
> - &num_cs);
> - ret = of_property_read_u32(pdev->dev.of_node,
> - "xlnx,num-transfer-bits",
> - &bits_per_word);
> + device_property_read_u32(&pdev->dev, "xlnx,num-ss-bits",
> + &num_cs);
> + ret = device_property_read_u32(&pdev->dev,
> + "xlnx,num-transfer-bits",
> + &bits_per_word);
> if (ret)
> bits_per_word = 8;
> }
> @@ -471,7 +471,7 @@ static int xilinx_spi_probe(struct platform_device *pdev)
> xspi->bytes_per_word = bits_per_word / 8;
> xspi->buffer_size = xilinx_spi_find_buffer_size(xspi);
>
> - xspi->irq = platform_get_irq(pdev, 0);
> + xspi->irq = platform_get_irq_optional(pdev, 0);
> if (xspi->irq < 0 && xspi->irq != -ENXIO) {
> return xspi->irq;
> } else if (xspi->irq >= 0) {
I expect this is another IP which you are using on systems with ACPI.
Can you share ASL fragment you use for testing?
Thanks,
Michal
More information about the linux-arm-kernel
mailing list