[PATCH 07/27] clk: bm1880: convert from divider_round_rate() to divider_determine_rate()
Manivannan Sadhasivam
mani at kernel.org
Thu Jan 15 21:24:33 PST 2026
On Thu, Jan 08, 2026 at 04:16:25PM -0500, Brian Masney wrote:
> The divider_round_rate() function is now deprecated, so let's migrate
> to divider_determine_rate() instead so that this deprecated API can be
> removed.
>
> Note that when the main function itself was migrated to use
> determine_rate, this was mistakenly converted to:
>
> req->rate = divider_round_rate(...)
>
> This is invalid in the case when an error occurs since it can set the
> rate to a negative value.
>
> Fixes: 64613d7fb42f ("clk: bm1880: convert from round_rate() to determine_rate()")
> Signed-off-by: Brian Masney <bmasney at redhat.com>
Acked-by: Manivannan Sadhasivam <mani at kernel.org>
- Mani
>
> ---
> To: Manivannan Sadhasivam <mani at kernel.org>
> Cc: linux-arm-kernel at lists.infradead.org
> ---
> drivers/clk/clk-bm1880.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/clk/clk-bm1880.c b/drivers/clk/clk-bm1880.c
> index 536df8e828eab83fbd3812135139c703aa7a1ce3..1bdceb36fa87e8250c10a7fc0791379e1533bb38 100644
> --- a/drivers/clk/clk-bm1880.c
> +++ b/drivers/clk/clk-bm1880.c
> @@ -625,10 +625,7 @@ static int bm1880_clk_div_determine_rate(struct clk_hw *hw,
> div->width, div->flags, val);
> }
>
> - req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate,
> - div->table, div->width, div->flags);
> -
> - return 0;
> + return divider_determine_rate(hw, req, div->table, div->width, div->flags);
> }
>
> static int bm1880_clk_div_set_rate(struct clk_hw *hw, unsigned long rate,
>
> --
> 2.52.0
>
--
மணிவண்ணன் சதாசிவம்
More information about the linux-arm-kernel
mailing list