[PATCH 1/3] PCI: j721e: Propagate dev_err_probe return value
Markus Elfring
Markus.Elfring at web.de
Sat Oct 18 01:56:13 PDT 2025
> Ensure that the return value from dev_err_probe() is consistently assigned
> back to ret in all error paths within j721e_pcie_probe(). This ensures
> the original error code are propagation for debugging.
I find the change description improvable.
I propose to take another source code transformation approach better into account.
https://elixir.bootlin.com/linux/v6.17.1/source/drivers/base/core.c#L5031-L5075
Example:
https://elixir.bootlin.com/linux/v6.17.1/source/drivers/pci/controller/cadence/pci-j721e.c#L444-L636
ret = dev_err_probe(dev, cdns_pcie_init_phy(dev, cdns_pcie), "Failed to init phy\n");
if (ret)
goto err_get_sync;
How do you think about to achieve such a source code variant also with the help of
the semantic patch language (Coccinelle software)?
Regards,
Markus
More information about the linux-arm-kernel
mailing list