[PATCH v1 1/3] PCI: j721e: Propagate dev_err_probe return value
Anand Moon
linux.amoon at gmail.com
Tue Oct 14 04:32:27 PDT 2025
Ensure that the return value from dev_err_probe() is consistently assigned
back to ret in all error paths within j721e_pcie_probe(). This ensures
the original error code are propagation for debugging.
Cc: Siddharth Vadapalli <s-vadapalli at ti.com>
Signed-off-by: Anand Moon <linux.amoon at gmail.com>
---
v1: new patch in this series
---
drivers/pci/controller/cadence/pci-j721e.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
index 5bc5ab20aa6d..9c7bfa77a66e 100644
--- a/drivers/pci/controller/cadence/pci-j721e.c
+++ b/drivers/pci/controller/cadence/pci-j721e.c
@@ -569,20 +569,20 @@ static int j721e_pcie_probe(struct platform_device *pdev)
pm_runtime_enable(dev);
ret = pm_runtime_get_sync(dev);
if (ret < 0) {
- dev_err_probe(dev, ret, "pm_runtime_get_sync failed\n");
+ ret = dev_err_probe(dev, ret, "pm_runtime_get_sync failed\n");
goto err_get_sync;
}
ret = j721e_pcie_ctrl_init(pcie);
if (ret < 0) {
- dev_err_probe(dev, ret, "j721e_pcie_ctrl_init failed\n");
+ ret = dev_err_probe(dev, ret, "j721e_pcie_ctrl_init failed\n");
goto err_get_sync;
}
ret = devm_request_irq(dev, irq, j721e_pcie_link_irq_handler, 0,
"j721e-pcie-link-down-irq", pcie);
if (ret < 0) {
- dev_err_probe(dev, ret, "failed to request link state IRQ %d\n", irq);
+ ret = dev_err_probe(dev, ret, "failed to request link state IRQ %d\n", irq);
goto err_get_sync;
}
@@ -599,7 +599,7 @@ static int j721e_pcie_probe(struct platform_device *pdev)
ret = cdns_pcie_init_phy(dev, cdns_pcie);
if (ret) {
- dev_err_probe(dev, ret, "Failed to init phy\n");
+ ret = dev_err_probe(dev, ret, "Failed to init phy\n");
goto err_get_sync;
}
@@ -611,7 +611,7 @@ static int j721e_pcie_probe(struct platform_device *pdev)
ret = clk_prepare_enable(clk);
if (ret) {
- dev_err_probe(dev, ret, "failed to enable pcie_refclk\n");
+ ret = dev_err_probe(dev, ret, "failed to enable pcie_refclk\n");
goto err_pcie_setup;
}
pcie->refclk = clk;
@@ -638,7 +638,7 @@ static int j721e_pcie_probe(struct platform_device *pdev)
case PCI_MODE_EP:
ret = cdns_pcie_init_phy(dev, cdns_pcie);
if (ret) {
- dev_err_probe(dev, ret, "Failed to init phy\n");
+ ret = dev_err_probe(dev, ret, "Failed to init phy\n");
goto err_get_sync;
}
--
2.50.1
More information about the linux-arm-kernel
mailing list