[PATCH 21/39] drm/imx: dc: crtc: Do not check disabled CRTCs

Marek Vasut marek.vasut at mailbox.org
Tue Oct 14 14:41:03 PDT 2025


On 10/13/25 8:50 PM, Frank Li wrote:
> On Sat, Oct 11, 2025 at 06:51:36PM +0200, Marek Vasut wrote:
>> If the CRTC is disabled, do not check it, as the check will fail.
>> Skip over the disabled CRTC.
> 
> sorry, I have not understand what means.

It means that on inactive CRTC, the atomic check below will fail because 
there is no valid mode, and the check itself makes no sense.

>> @@ -156,6 +156,10 @@ dc_crtc_atomic_check(struct drm_crtc *crtc, struct drm_atomic_state *state)
>>   	struct dc_crtc *dc_crtc = to_dc_crtc(crtc);
>>   	enum drm_mode_status status;
>>
>> +	/* If we are not active we don't care */
>> +	if (!new_crtc_state->active)
>> +		return 0;
>> +
>>   	status = dc_crtc_check_clock(dc_crtc, adj->clock);
>>   	if (status != MODE_OK)
>>   		return -EINVAL;




More information about the linux-arm-kernel mailing list