[PATCH 21/39] drm/imx: dc: crtc: Do not check disabled CRTCs

Frank Li Frank.li at nxp.com
Mon Oct 13 11:50:25 PDT 2025


On Sat, Oct 11, 2025 at 06:51:36PM +0200, Marek Vasut wrote:
> If the CRTC is disabled, do not check it, as the check will fail.
> Skip over the disabled CRTC.

sorry, I have not understand what means.

Frank

>
> Signed-off-by: Marek Vasut <marek.vasut at mailbox.org>
> ---
> Cc: Abel Vesa <abelvesa at kernel.org>
> Cc: Conor Dooley <conor+dt at kernel.org>
> Cc: Fabio Estevam <festevam at gmail.com>
> Cc: Krzysztof Kozlowski <krzk+dt at kernel.org>
> Cc: Laurent Pinchart <Laurent.pinchart at ideasonboard.com>
> Cc: Liu Ying <victor.liu at nxp.com>
> Cc: Lucas Stach <l.stach at pengutronix.de>
> Cc: Peng Fan <peng.fan at nxp.com>
> Cc: Pengutronix Kernel Team <kernel at pengutronix.de>
> Cc: Rob Herring <robh at kernel.org>
> Cc: Shawn Guo <shawnguo at kernel.org>
> Cc: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: devicetree at vger.kernel.org
> Cc: dri-devel at lists.freedesktop.org
> Cc: imx at lists.linux.dev
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-clk at vger.kernel.org
> ---
>  drivers/gpu/drm/imx/dc/dc-crtc.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/imx/dc/dc-crtc.c b/drivers/gpu/drm/imx/dc/dc-crtc.c
> index 56991cb033945..4955f519db917 100644
> --- a/drivers/gpu/drm/imx/dc/dc-crtc.c
> +++ b/drivers/gpu/drm/imx/dc/dc-crtc.c
> @@ -156,6 +156,10 @@ dc_crtc_atomic_check(struct drm_crtc *crtc, struct drm_atomic_state *state)
>  	struct dc_crtc *dc_crtc = to_dc_crtc(crtc);
>  	enum drm_mode_status status;
>
> +	/* If we are not active we don't care */
> +	if (!new_crtc_state->active)
> +		return 0;
> +
>  	status = dc_crtc_check_clock(dc_crtc, adj->clock);
>  	if (status != MODE_OK)
>  		return -EINVAL;
> --
> 2.51.0
>



More information about the linux-arm-kernel mailing list