[PATCH 16/16] media: rockchip: rga: add rga3 support

[Krzysztof Kozlowski]

On 08/10/2025 01:05, Sven Püschel wrote:
> Hi Krzysztof,
> 
> On 10/7/25 10:39 AM, Krzysztof Kozlowski wrote:
>> On 07/10/2025 17:32, Sven Püschel wrote:
>>> Add support for the RGA3 unit contained in the RK3588.
>>>
>>> Only a basic feature set consisting of scaling and color conversion is
>>> implemented. Advanced features like rotation and cropping will just be
>>> ignored. Also the BT601F color space conversion is currently hard coded.
>>>
>>> The register address defines were copied from the
>>> vendor Rockchip kernel sources and slightly adjusted to not start at 0
>>> again for the cmd registers.
>>>
>>> Signed-off-by: Sven Püschel <s.pueschel at pengutronix.de>
>>> ---
>>>   drivers/media/platform/rockchip/rga/Makefile  |   2 +-
>>>   drivers/media/platform/rockchip/rga/rga.c     |   4 +
>>>   drivers/media/platform/rockchip/rga/rga.h     |   2 +-
>>>   drivers/media/platform/rockchip/rga/rga3-hw.c | 490 ++++++++++++++++++++++++++
>>>   drivers/media/platform/rockchip/rga/rga3-hw.h | 186 ++++++++++
>>>   5 files changed, 682 insertions(+), 2 deletions(-)
>> Your order of patches is a mess. DTS cannot be in the middle. In fact,
>> DTS should not be even in this patchset, because you are targeting media.
> 
> sorry to bother you, but could you go into a bit more detail on how it 
> should be done correctly?

DTS cannot be before drivers, because this suggests that drivers depends
on DTS, which would be a NAK. See also maintainer soc profile. To avoid
having such impression of fake dependency, DTS must be placed at the end
of patchset (except the obvious part: nothing in your code can depend on
it).

Best regards,
Krzysztof