[PATCH 16/16] media: rockchip: rga: add rga3 support

[Nicolas Dufresne]

Hi Krzysztof,

Le mardi 07 octobre 2025 à 17:39 +0900, Krzysztof Kozlowski a écrit :
> On 07/10/2025 17:32, Sven Püschel wrote:
> > Add support for the RGA3 unit contained in the RK3588.
> > 
> > Only a basic feature set consisting of scaling and color conversion is
> > implemented. Advanced features like rotation and cropping will just be
> > ignored. Also the BT601F color space conversion is currently hard coded.
> > 
> > The register address defines were copied from the
> > vendor Rockchip kernel sources and slightly adjusted to not start at 0
> > again for the cmd registers.
> > 
> > Signed-off-by: Sven Püschel <s.pueschel at pengutronix.de>
> > ---
> >  drivers/media/platform/rockchip/rga/Makefile  |   2 +-
> >  drivers/media/platform/rockchip/rga/rga.c     |   4 +
> >  drivers/media/platform/rockchip/rga/rga.h     |   2 +-
> >  drivers/media/platform/rockchip/rga/rga3-hw.c | 490
> > ++++++++++++++++++++++++++
> >  drivers/media/platform/rockchip/rga/rga3-hw.h | 186 ++++++++++
> >  5 files changed, 682 insertions(+), 2 deletions(-)
> 
> Your order of patches is a mess. DTS cannot be in the middle. In fact,
> DTS should not be even in this patchset, because you are targeting media.

Indeed, order is broken, though I do appreciate having the DTS as part of the
submission, this way I don't have to chase for them when testing. That being
said, a link or message ID in the cover later would be as good.

Nicolas

> 
> Best regards,
> Krzysztof
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20251007/76893dba/attachment.sig>