[PATCH v4 2/2] arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC

[Heiko Stübner]

Am Freitag, 23. Mai 2025, 09:12:08 Mitteleuropäische Sommerzeit schrieb Krzysztof Kozlowski:
> On 23/05/2025 09:00, Chukun Pan wrote:
> > 
> >> +&gmac1 {
> >> +	clock_in_out = "output";
> >> +	phy-handle = <&rgmii_phy1>;
> >> +	phy-mode = "rgmii-id";
> >> +	pinctrl-0 = ...
> >> +	pinctrl-names = "default";
> > 
> > pinctrl-names should be placed before pinctrl-0
> 
> That's unusual - not inline with common coding style and with most of
> SoCs. Is this some kind of known rule valid in Rockchip?

nope it isn't any sort of rule :-) .


I _think_ in the past we generally had
pinctrl-names = "defaule", "whatever"
pinctrl-0 =
pinctrl-1 =

but that was more a "looking somewhat nice" thing from before we had the
more generic dts coding style .


So if in doubt nowadays, please follow the general coding style as written
down in
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst


Heiko