[PATCH v4 2/2] arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Fri May 23 00:12:08 PDT 2025


On 23/05/2025 09:00, Chukun Pan wrote:
> 
>> +&gmac1 {
>> +	clock_in_out = "output";
>> +	phy-handle = <&rgmii_phy1>;
>> +	phy-mode = "rgmii-id";
>> +	pinctrl-0 = ...
>> +	pinctrl-names = "default";
> 
> pinctrl-names should be placed before pinctrl-0

That's unusual - not inline with common coding style and with most of
SoCs. Is this some kind of known rule valid in Rockchip?

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list