[PATCH v2 1/5] watchdog: s3c2410_wdt: Replace hardcoded values with macro definitions

Krzysztof Kozlowski krzk at kernel.org
Wed May 14 02:59:23 PDT 2025


On 14/05/2025 11:42, Sangwook Shin wrote:
> Modify the code to utilize macro-defined values instead of hardcoded
> values. The value 0x100 in the s3c2410wdt_set_heartbeat function represents
> S3C2410_WTCON_PRESCALE_MAX + 1, but it is hardcoded, making its meaning
> difficult to understand and reducing code readability.
> 
> Signed-off-by: Sangwook Shin <sw617.shin at samsung.com>
> Signed-off-by: Kyunghwan Seo <khwan.seo at samsung.com>
Your DCO is not looking correct. You must be the last signing person.
What is actually Kyunghwan's contribution here and what does his SoB
mean? Who wrote the patch?

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list