[PATCH v2 1/5] watchdog: s3c2410_wdt: Replace hardcoded values with macro definitions
Sangwook Shin
sw617.shin at samsung.com
Wed May 14 02:42:16 PDT 2025
Modify the code to utilize macro-defined values instead of hardcoded
values. The value 0x100 in the s3c2410wdt_set_heartbeat function represents
S3C2410_WTCON_PRESCALE_MAX + 1, but it is hardcoded, making its meaning
difficult to understand and reducing code readability.
Signed-off-by: Sangwook Shin <sw617.shin at samsung.com>
Signed-off-by: Kyunghwan Seo <khwan.seo at samsung.com>
---
drivers/watchdog/s3c2410_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c
index bdd81d8074b2..228f86d83663 100644
--- a/drivers/watchdog/s3c2410_wdt.c
+++ b/drivers/watchdog/s3c2410_wdt.c
@@ -555,7 +555,7 @@ static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd,
if (count >= 0x10000) {
divisor = DIV_ROUND_UP(count, 0xffff);
- if (divisor > 0x100) {
+ if (divisor > S3C2410_WTCON_PRESCALE_MAX + 1) {
dev_err(wdt->dev, "timeout %d too big\n", timeout);
return -EINVAL;
}
--
2.40.1
More information about the linux-arm-kernel
mailing list