[PATCH 4/6] arm64: dts: rockchip: add px30-cobra base dtsi and board variants
Quentin Schulz
quentin.schulz at cherry.de
Mon May 12 12:48:37 PDT 2025
Hi Heiko,
On 5/8/25 5:09 PM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner at cherry.de>
>
> Cobra are Touchscreen devices built around the PX30 SoC using
> a variety of display options.
>
> The devices feature an EMMC, network port, usb host + OTG ports and
> a 720x1280 display with a touchscreen.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner at cherry.de>
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 4 +
> .../rockchip/px30-cobra-ltk050h3146w-a2.dts | 39 ++
> .../dts/rockchip/px30-cobra-ltk050h3146w.dts | 39 ++
> .../dts/rockchip/px30-cobra-ltk050h3148w.dts | 39 ++
> .../dts/rockchip/px30-cobra-ltk500hd1829.dts | 58 ++
> arch/arm64/boot/dts/rockchip/px30-cobra.dtsi | 570 ++++++++++++++++++
> 6 files changed, 749 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts
> create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w.dts
> create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3148w.dts
> create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk500hd1829.dts
> create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra.dtsi
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 3e8771ef69ba..8151e8bb1cd3 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -1,4 +1,8 @@
> # SPDX-License-Identifier: GPL-2.0
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk050h3146w-a2.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk050h3146w.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk050h3148w.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-cobra-ltk500hd1829.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-evb.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2-of10.dtb
> diff --git a/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts
> new file mode 100644
> index 000000000000..1d26164be7b8
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts
> @@ -0,0 +1,39 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2025 Cherry Embedded Solutions GmbH
> + */
> +
> +/dts-v1/;
> +#include "px30-cobra.dtsi"
> +
> +/ {
> + model = "Theobroma Systems Cobra with LTK050H3146W-A2 Display";
> + compatible = "tsd,px30-cobra-ltk050h3146w-a2", "tsd,px30-cobra", "rockchip,px30";
> +};
> +
> +&dsi {
> + status = "okay";
> +
> + panel at 0 {
> + compatible = "leadtek,ltk050h3146w-a2";
> + reg = <0>;
> + backlight = <&backlight>;
> + iovcc-supply = <&vcc_1v8>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&dsp_rst>;
> + reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
> + vci-supply = <&vcc_2v8>;
> +
> + port {
> + mipi_in_panel: endpoint {
> + remote-endpoint = <&mipi_out_panel>;
> + };
> + };
> + };
> +};
> +
> +&dsi_out {
> + mipi_out_panel: endpoint {
> + remote-endpoint = <&mipi_in_panel>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w.dts b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w.dts
> new file mode 100644
> index 000000000000..82c6acdb4fae
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w.dts
> @@ -0,0 +1,39 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2025 Cherry Embedded Solutions GmbH
> + */
> +
> +/dts-v1/;
> +#include "px30-cobra.dtsi"
> +
> +/ {
> + model = "Theobroma Systems Cobra with LTK050H3146W Display";
> + compatible = "tsd,px30-cobra-ltk050h3146w", "tsd,px30-cobra", "rockchip,px30";
> +};
> +
> +&dsi {
> + status = "okay";
> +
> + panel at 0 {
> + compatible = "leadtek,ltk050h3146w";
> + reg = <0>;
> + backlight = <&backlight>;
> + iovcc-supply = <&vcc_1v8>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&dsp_rst>;
> + reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
> + vci-supply = <&vcc_2v8>;
> +
> + port {
> + mipi_in_panel: endpoint {
> + remote-endpoint = <&mipi_out_panel>;
> + };
> + };
> + };
> +};
> +
> +&dsi_out {
> + mipi_out_panel: endpoint {
> + remote-endpoint = <&mipi_in_panel>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3148w.dts b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3148w.dts
> new file mode 100644
> index 000000000000..94449132df38
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3148w.dts
> @@ -0,0 +1,39 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2025 Cherry Embedded Solutions GmbH
> + */
> +
> +/dts-v1/;
> +#include "px30-cobra.dtsi"
> +
> +/ {
> + model = "Theobroma Systems Cobra with ltk050h3148w Display";
> + compatible = "tsd,px30-cobra-ltk050h3148w", "tsd,px30-cobra", "rockchip,px30";
> +};
> +
> +&dsi {
> + status = "okay";
> +
> + panel at 0 {
> + compatible = "leadtek,ltk050h3148w";
> + reg = <0>;
> + backlight = <&backlight>;
> + iovcc-supply = <&vcc_1v8>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&dsp_rst>;
> + reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
> + vci-supply = <&vcc_2v8>;
> +
> + port {
> + mipi_in_panel: endpoint {
> + remote-endpoint = <&mipi_out_panel>;
> + };
> + };
> + };
> +};
> +
> +&dsi_out {
> + mipi_out_panel: endpoint {
> + remote-endpoint = <&mipi_in_panel>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/rockchip/px30-cobra-ltk500hd1829.dts b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk500hd1829.dts
> new file mode 100644
> index 000000000000..418b4b4daaa3
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/px30-cobra-ltk500hd1829.dts
> @@ -0,0 +1,58 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2025 Cherry Embedded Solutions GmbH
> + */
> +
> +/dts-v1/;
> +#include "px30-cobra.dtsi"
> +
> +/ {
> + model = "Theobroma Systems Cobra prototype with LTK500HD1829 Display";
> + compatible = "tsd,px30-cobra-ltk500hd1829", "tsd,px30-cobra", "rockchip,px30";
> +
> + aliases {
> + mmc1 = &sdmmc;
> + };
> +};
> +
> +&dsi {
> + status = "okay";
> +
> + panel at 0 {
> + compatible = "leadtek,ltk500hd1829";
> + reg = <0>;
> + backlight = <&backlight>;
> + iovcc-supply = <&vcc_1v8>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&dsp_rst>;
> + reset-gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
> + vcc-supply = <&vcc_2v8>;
> +
> + port {
> + mipi_in_panel: endpoint {
> + remote-endpoint = <&mipi_out_panel>;
> + };
> + };
> + };
> +};
> +
> +&dsi_out {
> + mipi_out_panel: endpoint {
> + remote-endpoint = <&mipi_in_panel>;
> + };
> +};
> +
> +&sdmmc {
> + bus-width = <4>;
> + broken-cd;
> + cap-sd-highspeed;
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>;
> + sd-uhs-sdr12;
> + sd-uhs-sdr25;
> + sd-uhs-sdr50;
> + sd-uhs-sdr104;
> + vmmc-supply = <&vccio_sd>;
> + vqmmc-supply = <&vccio_sd>;
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/rockchip/px30-cobra.dtsi b/arch/arm64/boot/dts/rockchip/px30-cobra.dtsi
> new file mode 100644
> index 000000000000..92066cbc1a70
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/px30-cobra.dtsi
> @@ -0,0 +1,570 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2025 Cherry Embedded Solutions GmbH
> + */
> +
> +/dts-v1/;
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/pinctrl/rockchip.h>
> +#include "px30.dtsi"
> +
> +/ {
> + aliases {
> + mmc0 = &emmc;
ethernet0 = &gmac;
maybe?
> + };
> +
> + chosen {
> + stdout-path = "serial5:115200n8";
> + };
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + power-supply = <&vcc5v0_sys>;
> + pwms = <&pwm0 0 25000 0>;
> + };
> +
> + beeper {
> + compatible = "pwm-beeper";
> + pwms = <&pwm1 0 1000 0>;
> + };
> +
> + emmc_pwrseq: emmc-pwrseq {
> + compatible = "mmc-pwrseq-emmc";
> + pinctrl-0 = <&emmc_reset>;
> + pinctrl-names = "default";
> + reset-gpios = <&gpio1 RK_PB3 GPIO_ACTIVE_HIGH>;
> + };
> +
> + gpio-leds {
> + compatible = "gpio-leds";
> +
> + led-0 {
> + color = <LED_COLOR_ID_BLUE>;
> + gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>;
Missing pinctrl here. (which we probably need in gpio-leds actually?)
Can you add a comment that is supposed to be LED14 on the PCB? I'll
check in the next few days but it's possible it's not always placed so a
comment stating that would be nice too :) Please remind me if I don't
tell you in the next few days.
> + label = "heartbeat";
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +
> + pwm-leds {
> + compatible = "pwm-leds";
> +
> + ring_red: led-0 {
> + color = <LED_COLOR_ID_RED>;
> + default-state = "off";
> + label = "ring_red";
> + pwms = <&pwm5 0 1000000 0>;
> + max-brightness = <255>;
> + };
> +
> + ring_green: led-1 {
> + color = <LED_COLOR_ID_GREEN>;
> + default-state = "off";
> + label = "ring_green";
> + pwms = <&pwm6 0 1000000 0>;
> + max-brightness = <255>;
> + };
> +
> + ring_blue: led-2 {
> + color = <LED_COLOR_ID_BLUE>;
> + default-state = "off";
> + label = "ring_blue";
> + pwms = <&pwm7 0 1000000 0>;
> + max-brightness = <255>;
> + };
> + };
> +
> + /* also named 5V_Q7 in schematics */
> + vcc5v0_sys: regulator-vccsys {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_sys";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + };
> +};
> +
> +&cpu0 {
> + cpu-supply = <&vdd_arm>;
> +};
> +
> +&cpu1 {
> + cpu-supply = <&vdd_arm>;
> +};
> +
> +&cpu2 {
> + cpu-supply = <&vdd_arm>;
> +};
> +
> +&cpu3 {
> + cpu-supply = <&vdd_arm>;
> +};
> +
> +&display_subsystem {
> + status = "okay";
> +};
> +
> +&dsi_dphy {
> + status = "okay";
> +};
> +
> +&emmc {
> + bus-width = <8>;
> + cap-mmc-highspeed;
> + /*
> + * For hs200 support, U-Boot would have to set the RK809 DCDC4
> + * rail to 1.8V from the default of 3.0V. It doesn't do that on
> + * devices out in the field, so disable hs200.
> + * mmc-hs200-1_8v;
> + */
> + mmc-pwrseq = <&emmc_pwrseq>;
> + non-removable;
> + vmmc-supply = <&vcc_3v3>;
> + vqmmc-supply = <&vcc_emmc>;
> + status = "okay";
> +};
> +
> +&gmac {
> + clock_in_out = "output";
> + phy-handle = <&dp83825>;
> + phy-supply = <&vcc_3v3>;
> + status = "okay";
> +};
> +
> +&gpu {
> + mali-supply = <&vdd_log>;
> + status = "okay";
> +};
> +
> +/* I2C0 = PMIC, STUSB4500, RTC */
> +&i2c0 {
> + status = "okay";
> +
> + rk809: pmic at 20 {
> + compatible = "rockchip,rk809";
> + reg = <0x20>;
> + #clock-cells = <0>;
> + clock-output-names = "xin32k";
> + interrupt-parent = <&gpio0>;
> + interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
Can you use RK_PA7 here instead of 7?
> + pinctrl-names = "default";
> + pinctrl-0 = <&pmic_int>;
> + wakeup-source;
> + rockchip,system-power-controller;
> +
> + vcc1-supply = <&vcc5v0_sys>;
> + vcc2-supply = <&vcc5v0_sys>;
> + vcc3-supply = <&vcc5v0_sys>;
> + vcc4-supply = <&vcc5v0_sys>;
> + vcc5-supply = <&vcc_3v3>;
> + vcc6-supply = <&vcc_3v3>;
> + vcc7-supply = <&vcc_3v3>;
> + vcc9-supply = <&vcc5v0_sys>;
> +
> + regulators {
> + vdd_log: DCDC_REG1 {
> + regulator-name = "vdd_log";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <950000>;
> + regulator-max-microvolt = <1350000>;
> + regulator-ramp-delay = <6001>;
> +
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + regulator-suspend-microvolt = <950000>;
> + };
> + };
> +
> + vdd_arm: DCDC_REG2 {
> + regulator-name = "vdd_arm";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <950000>;
> + regulator-max-microvolt = <1350000>;
> + regulator-ramp-delay = <6001>;
> +
> + regulator-state-mem {
> + regulator-off-in-suspend;
> + regulator-suspend-microvolt = <950000>;
> + };
> + };
> +
> + vcc_ddr: DCDC_REG3 {
> + regulator-name = "vcc_ddr";
> + regulator-always-on;
> + regulator-boot-on;
> +
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + };
> + };
> +
> + vcc_3v3: DCDC_REG5 {
> + regulator-name = "vcc_3v3";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> +
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + regulator-suspend-microvolt = <3300000>;
> + };
> + };
> +
> + vcc_3v0_1v8: vcc_emmc: DCDC_REG4 {
> + regulator-name = "vcc_3v0_1v8";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3000000>;
> +
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + regulator-suspend-microvolt = <3000000>;
> + };
> + };
> +
Please have DCDC_REG4 before DCDC_REG5?
> + vcc_1v8: LDO_REG2 {
> + regulator-name = "vcc_1v8";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> +
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + regulator-suspend-microvolt = <1800000>;
> + };
> + };
> +
> + vcc_1v0: LDO_REG3 {
> + regulator-name = "vcc_1v0";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> +
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + regulator-suspend-microvolt = <1000000>;
> + };
> + };
> +
> + vcc_2v8: LDO_REG4 {
> + regulator-name = "vcc_2v8";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> +
> + regulator-state-mem {
> + regulator-off-in-suspend;
> + regulator-suspend-microvolt = <2800000>;
> + };
> + };
> +
> + /*
> + * vccio_sd also supplies the vmmc supply, so needs
> + * to stay single voltage.
> + */
Please check on your prototype's schematics but this is routed to VCCIO2
IO domain only (which isn't used for anything), so I would say this is
not a relevant comment anymore?
> + vccio_sd: LDO_REG5 {
> + regulator-name = "vccio_sd";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3000000>;
> +
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + regulator-suspend-microvolt = <3000000>;
> + };
> + };
> +
> + /* vcc_sdio also supplies the pull-up resistors for i2c1 */
> + vcc_sdio: LDO_REG6 {
> + regulator-name = "vcc_sdio";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3000000>;
> +
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + regulator-suspend-microvolt = <3300000>;
> + };
> + };
> +
> + vcc_lcd: LDO_REG7 {
> + regulator-name = "vcc_lcd";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> +
> + regulator-state-mem {
> + regulator-off-in-suspend;
> + regulator-suspend-microvolt = <1000000>;
> + };
> + };
> +
> + vcc_1v8_lcd: LDO_REG8 {
> + regulator-name = "vcc_1v8_lcd";
Technically called 1v8_lcd, but can stay like this :)
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> +
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + regulator-suspend-microvolt = <1800000>;
> + };
> + };
> +
> + vcca_1v8: LDO_REG9 {
> + regulator-name = "vcca_1v8";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> +
> + regulator-state-mem {
> + regulator-off-in-suspend;
> + regulator-suspend-microvolt = <1800000>;
> + };
> + };
> + };
> + };
> +};
> +
> +&i2c1 {
> + clock-frequency = <100000>;
> + status = "okay";
> +};
> +
> +&i2c2 {
> + clock-frequency = <100000>;
> + i2c-scl-falling-time-ns = <50>;
> + i2c-scl-rising-time-ns = <300>;
> + status = "okay";
> +
> + touchscreen at 14 {
> + compatible = "goodix,gt911";
> + reg = <0x14>;
> + interrupt-parent = <&gpio0>;
> + interrupts = <RK_PA1 IRQ_TYPE_LEVEL_LOW>;
> + irq-gpios = <&gpio0 RK_PA1 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&tch_int &tch_rst>;
> + reset-gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>;
> + touchscreen-inverted-x;
> + AVDD28-supply = <&vcc_2v8>;
> + VDDIO-supply = <&vcc_3v3>;
I couldn't find at a glance whether the alphanum order required for DTs
is case sensitive? But considering we ignore # before properties when
doing alphanum order, I guess it's case insensitive too?
> + };
> +};
> +
> +/*
> + * Enable pull-ups to prevent floating pins when the touch
> + * panel is not connected.
> + */
> +&i2c2_xfer {
> + rockchip,pins =
> + <2 RK_PB7 2 &pcfg_pull_up>,
> + <2 RK_PC0 2 &pcfg_pull_up>;
> +};
> +
> +&io_domains {
> + vccio1-supply = <&vcc_sdio>;
> + vccio2-supply = <&vccio_sd>;
> + vccio3-supply = <&vcc_3v3>;
> + vccio4-supply = <&vcc_3v3>;
> + vccio5-supply = <&vcc_1v8>;
> + vccio6-supply = <&vcc_emmc>;
> + status = "okay";
> +};
> +
> +&mdio {
> + dp83825: ethernet-phy at 0 {> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0x0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&phy_rst>;
> + reset-assert-us = <50000>;
> + reset-deassert-us = <50000>;
> + reset-gpios = <&gpio2 RK_PB6 GPIO_ACTIVE_LOW>;
Seems like we have an interrupt pin here as well with PWRDOWN pin?
Though it seems it could also be used as a power down bit (driving low
when entering low power mode). Not sure what's desired here for the
product, so I guess we are fine. The datasheet says it's open-drain with
an internal pull-up of 9.5kOhm and the default for GPIO2_B4 seems to be
pull-down, but likely weaker than the 9.5kOhm otherwise Ethernet would
simply not work :)
> + };
> +};
> +
> +&pinctrl {
> + pinctrl-names = "default";
> + pinctrl-0 = <&cobra_pin_hog>;
> +
> + hog {
> + cobra_pin_hog: cobra_pin_hog {
No underscores in node names.
> + rockchip,pins =
> + /* STUSB4500 open drain outout POWER_OK2, needs pull-up */
> + <3 RK_PB1 RK_FUNC_GPIO &pcfg_pull_up>,
> + /* STUSB4500 open drain outout POWER_OK3, needs pull-up */
> + <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>,
Interesting... Those aren't routed on my schematics, will need to check
earlier versions/variants.
> + /* The default pull-down can keep the IC in reset. */
> + <3 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>,
> + /* USB-A 5V enable */
> + <3 RK_PC0 RK_FUNC_GPIO &pcfg_output_high>,
> + /* USB-A data enable */
> + <3 RK_PD3 RK_FUNC_GPIO &pcfg_output_high>,
> + /* USB_HUB1_RESET */
> + <0 RK_PB4 RK_FUNC_GPIO &pcfg_output_high>,
> + /* USB_HUB2_RESET */
> + <0 RK_PA4 RK_FUNC_GPIO &pcfg_output_high>;
Uuuuuh it's GPIO0_A5 for me, can you triple check on your schematics?
Would be nice if you could order them all by gpio bank + number?
> + };
> + };
> +
> + emmc {
> + emmc_reset: emmc-reset {
> + rockchip,pins =
> + <1 RK_PB3 RK_FUNC_GPIO &pcfg_pull_none>;
Will need to check the JEDEC standard, it's directly routed to the eMMC
chip so maybe we need a PU/PD.
> + };
> + };
> +
> + ethernet {
> + phy_rst: phy-rst {
> + rockchip,pins =
> + <2 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> +
> + panel {
> + tch_int: tch-int {
> + rockchip,pins =
> + <0 RK_PA1 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> +
> + tch_rst: tch-rst {
> + rockchip,pins =
> + <0 RK_PB5 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> +
> + dsp_rst: dsp-rst {
> + rockchip,pins =
> + <0 RK_PB2 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
I know for the touch controller no PU/PD is required, but I'm not too
sure about the display controller, and since it's directly routed...
Maybe we should have something there? Need to check with HW department :)
> + };
> +
> + pmic {
> + pmic_int: pmic-int {
> + rockchip,pins =
> + <0 RK_PA7 RK_FUNC_GPIO &pcfg_pull_up>;
> + };
> +
> + soc_slppin_pin: soc-slppin {
> + rockchip,pins =
> + <0 RK_PA4 RK_FUNC_GPIO &pcfg_output_low>;
> + };
> +
> + soc_slppin_slp: soc-slppin-slp {
> + rockchip,pins =
> + <0 RK_PA4 1 &pcfg_pull_none>;
> + };
> +
> + soc_slppin_rst: soc-slppin-rst {
> + rockchip,pins =
> + <0 RK_PA4 2 &pcfg_pull_none>;
> + };
All soc_slppin* pinmux don't seem to be used, maybe remove them then?
Cheers,
Quentin
More information about the linux-arm-kernel
mailing list