[PATCH 2/9] drivers/perf: hisi: Simplify the probe process for each DDRC version
Jonathan Cameron
Jonathan.Cameron at huawei.com
Tue Mar 4 01:26:49 PST 2025
On Tue, 18 Feb 2025 17:19:53 +0800
Yicong Yang <yangyicong at huawei.com> wrote:
> From: Junhao He <hejunhao3 at huawei.com>
>
> Version 1 and 2 of DDRC PMU also use different HID. Make use of
> struct acpi_device_id::driver_data for version specific information
> rather than judge the version register. This will help to
> simplify the probe process and also a bit easier for extension.
>
> Signed-off-by: Junhao He <hejunhao3 at huawei.com>
> Signed-off-by: Yicong Yang <yangyicong at hisilicon.com>
Looks good to me. Looking at this I can see the check_reg naming
is an existing thing so maybe leave that alone for now and consider
renaming as a future improvement in readability.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron at huawei.com>
More information about the linux-arm-kernel
mailing list