[PATCH 2/4] thermal: qoriq: add i.MX93 TMU support

[Jacky Bai]

> Subject: Re: [PATCH 2/4] thermal: qoriq: add i.MX93 TMU support
> 
...

> > +325,9 @@ static int qoriq_tmu_probe(struct platform_device *pdev)
> >
> >  	data->ver = (ver >> 8) & 0xff;
> >
> > +	if (of_find_compatible_node(NULL, NULL, "fsl,imx93-tmu"))
> > +		data->ver = TMU_VER93;
> 
> No, you have driver match data for this.
> 

No compatible specific data info provided in the driver, will use
the 'of_device_is_compatible' to refine the above changes.

> Anyway, are you sure devices are compatible how you expressed in the
> bindings?
> 

The tmu hardware version read from the ID register is not designed as expected.
With the qoriq compatible, the tmu device can work on i.MX93. but for i.MX93,
the Central Module Configuration value suggested by design is not the same as on
QorIQ platform, and there is a TMU SW workaround need be applied on i.MX93
due to HW bug.

BR
Jacky Bai
> > +
> >  	qoriq_tmu_init_device(data);	/* TMU initialization */
> >
> >  	ret = qoriq_tmu_calibration(dev, data);	/* TMU calibration */
> > @@ -379,6 +388,7 @@ static
> DEFINE_SIMPLE_DEV_PM_OPS(qoriq_tmu_pm_ops,
> >  static const struct of_device_id qoriq_tmu_match[] = {
> >  	{ .compatible = "fsl,qoriq-tmu", },
> >  	{ .compatible = "fsl,imx8mq-tmu", },
> > +	{ .compatible = "fsl,imx93-tmu", },
> 
> Otherwise I claim devices are compatible and this should be dropped.
> 
> 
> 
> Best regards,
> Krzysztof