[PATCH 0/2] iommu/arm-smmu-v3: Two vsmmu impl_ops cleanups
Nicolin Chen
nicolinc at nvidia.com
Fri Jul 18 16:48:20 PDT 2025
Since the vsmmu and cmdqv patches were accepeted via the iommufd tree,
this is based on Jason's for-next tree.
Per request from Will following the accepted latest vcmdq series to clean
up the impl_ops:
https://lore.kernel.org/linux-iommu/aHE4Y-fbucm-j-yi@willie-the-truck/
"
It would be nice to avoid adding data members to the ops structure, if
at all possible. The easiest thing would probably be to add a function
for getting the vsmmu size and then pushing the two checks against
'vsmmu_type' down into the impl_ops callbacks so that:
1. If the type is IOMMU_VIOMMU_TYPE_ARM_SMMUV3, we don't bother with
the impl_ops at all in arm_vsmmu_init() and arm_smmu_get_viommu_size()
2. Otherwise, we pass the type into the impl_ops and they can check it
Of course, that can be a patch on top of the series as there's no point
respinning the whole just for this.
"
Add two clean up patches with the first one doing 1 and 2 to prioritize
IOMMU_VIOMMU_TYPE_ARM_SMMUV3 always, and the second one dropping static
vsmmu_type and vsmmu_size data members.
Nicolin Chen (2):
iommu/arm-smmu-v3: Do not bother impl_ops if
IOMMU_VIOMMU_TYPE_ARM_SMMUV3
iommu/arm-smmu-v3: Replace vsmmu_size/type with get_viommu_size
.../arm/arm-smmu-v3/arm-smmu-v3-iommufd.c | 26 +++++++++++--------
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 3 +--
.../iommu/arm/arm-smmu-v3/tegra241-cmdqv.c | 14 ++++++++--
3 files changed, 28 insertions(+), 15 deletions(-)
base-commit: ab6bc44159d8f0c4ee757e0ce041fa9033e0ead8
--
2.43.0
More information about the linux-arm-kernel
mailing list