[PATCH v3 1/4] dt-bindings: soc: samsung: usi: replace USI_V2 in constants with USI_MODE
Krzysztof Kozlowski
krzk at kernel.org
Sun Jan 5 23:28:45 PST 2025
On 06/01/2025 08:09, Ivaylo Ivanov wrote:
>>>
>>> -#define USI_V2_NONE 0
>>> -#define USI_V2_UART 1
>>> -#define USI_V2_SPI 2
>>> -#define USI_V2_I2C 3
>>> +#define USI_MODE_NONE 0
>>> +#define USI_MODE_UART 1
>>> +#define USI_MODE_SPI 2
>>> +#define USI_MODE_I2C 3
>> This breaks ABI and does not build. You still need also:
>> #define USI_V2_NONE USI_MODE_NONE
>> and same for the rest.
>
> Alright, sounds good to me. That way I shouldn't s/USI_V2/USI_MODE/g
> for the other SoC device trees, right? Should I also mention with a
You can change them as well, because USI_MODE_XXX will be preferred from
now on. The DTS commit will just wait one cycle till bindings get accepted.
> comment that the V2 constants are deprecated?
Yes, this would be good.
Thanks for working on this.
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list