[PATCH v3 1/4] dt-bindings: soc: samsung: usi: replace USI_V2 in constants with USI_MODE
Ivaylo Ivanov
ivo.ivanov.ivanov1 at gmail.com
Sun Jan 5 23:09:18 PST 2025
On 1/6/25 08:24, Krzysztof Kozlowski wrote:
> On Sun, Jan 05, 2025 at 06:03:43PM +0200, Ivaylo Ivanov wrote:
>> diff --git a/include/dt-bindings/soc/samsung,exynos-usi.h b/include/dt-bindings/soc/samsung,exynos-usi.h
>> index a01af169d..b7c1406f3 100644
>> --- a/include/dt-bindings/soc/samsung,exynos-usi.h
>> +++ b/include/dt-bindings/soc/samsung,exynos-usi.h
>> @@ -9,9 +9,9 @@
>> #ifndef __DT_BINDINGS_SAMSUNG_EXYNOS_USI_H
>> #define __DT_BINDINGS_SAMSUNG_EXYNOS_USI_H
>>
>> -#define USI_V2_NONE 0
>> -#define USI_V2_UART 1
>> -#define USI_V2_SPI 2
>> -#define USI_V2_I2C 3
>> +#define USI_MODE_NONE 0
>> +#define USI_MODE_UART 1
>> +#define USI_MODE_SPI 2
>> +#define USI_MODE_I2C 3
> This breaks ABI and does not build. You still need also:
> #define USI_V2_NONE USI_MODE_NONE
> and same for the rest.
Alright, sounds good to me. That way I shouldn't s/USI_V2/USI_MODE/g
for the other SoC device trees, right? Should I also mention with a
comment that the V2 constants are deprecated?
Best regards,
Ivaylo
>
> Best regards,
> Krzysztof
>
More information about the linux-arm-kernel
mailing list