[PATCH RFC net-next 3/5] net: stmmac: simplify phylink_suspend() and phylink_resume() calls
Andrew Lunn
andrew at lunn.ch
Thu Feb 27 08:45:35 PST 2025
> @@ -7927,13 +7925,9 @@ int stmmac_resume(struct device *dev)
> }
>
> rtnl_lock();
> - if (device_may_wakeup(priv->device) && priv->plat->pmt) {
> - phylink_resume(priv->phylink);
> - } else {
> - phylink_resume(priv->phylink);
> - if (device_may_wakeup(priv->device))
> - phylink_speed_up(priv->phylink);
> - }
> + phylink_resume(priv->phylink);
> + if (device_may_wakeup(priv->device) && !priv->plat->pmt)
> + phylink_speed_up(priv->phylink);
> rtnl_unlock();
>
> rtnl_lock();
Unrelated to this patch, but unlock() followed by lock()? Seems like
some more code which could be cleaned up?
Reviewed-by: Andrew Lunn <andrew at lunn.ch>
Andrew
More information about the linux-arm-kernel
mailing list