[PATCH net-next v2] net: stmmac: visconti: convert to set_clk_tx_rate() method

[nobuhiro1.iwamatsu at toshiba.co.jp]

> -----Original Message-----
> From: Russell King <rmk at armlinux.org.uk> On Behalf Of Russell King (Oracle)
> Sent: Wednesday, April 16, 2025 6:44 PM
> To: Andrew Lunn <andrew at lunn.ch>; Heiner Kallweit
> <hkallweit1 at gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue at foss.st.com>; Andrew Lunn
> <andrew+netdev at lunn.ch>; David S. Miller <davem at davemloft.net>; Eric
> Dumazet <edumazet at google.com>; Jakub Kicinski <kuba at kernel.org>;
> linux-arm-kernel at lists.infradead.org;
> linux-stm32 at st-md-mailman.stormreply.com; Maxime Coquelin
> <mcoquelin.stm32 at gmail.com>; netdev at vger.kernel.org; iwamatsu
> nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro1.iwamatsu at toshiba.co.jp>; Paolo Abeni <pabeni at redhat.com>
> Subject: [PATCH net-next v2] net: stmmac: visconti: convert to
> set_clk_tx_rate() method
> 
> Convert visconti to use the set_clk_tx_rate() method. By doing so, the GMAC
> control register will already have been updated (unlike with the
> fix_mac_speed() method) so this code can be removed while porting to the
> set_clk_tx_rate() method.
> 
> There is also no need for the spinlock, and has never been - neither
> fix_mac_speed() nor set_clk_tx_rate() can be called by more than one thread at
> a time, so the lock does nothing useful.
> 
> Reviewed-by: Andrew Lunn <andrew at lunn.ch>
> Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>
> ---
> v2: add Andrew's r-b (he doesn't mind it being preserved for simple fixes) fix
> build errors.
> 
>  .../ethernet/stmicro/stmmac/dwmac-visconti.c  | 23 +++++--------------
>  1 file changed, 6 insertions(+), 17 deletions(-)

Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu at toshiba.co.jp>

Best regards,
  Nobuhiro