[PATCH net-next v2] net: stmmac: visconti: convert to set_clk_tx_rate() method

Jacob Keller jacob.e.keller at intel.com
Wed Apr 16 13:19:06 PDT 2025



On 4/16/2025 2:43 AM, Russell King (Oracle) wrote:
> Convert visconti to use the set_clk_tx_rate() method. By doing so,
> the GMAC control register will already have been updated (unlike with
> the fix_mac_speed() method) so this code can be removed while porting
> to the set_clk_tx_rate() method.
> 
> There is also no need for the spinlock, and has never been - neither
> fix_mac_speed() nor set_clk_tx_rate() can be called by more than one
> thread at a time, so the lock does nothing useful.
> 
> Reviewed-by: Andrew Lunn <andrew at lunn.ch>
> Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>
> ---
> v2: add Andrew's r-b (he doesn't mind it being preserved for simple fixes)
> fix build errors.
> 

Reviewed-by: Jacob Keller <jacob.e.keller at intel.com>



More information about the linux-arm-kernel mailing list