[PATCH v6 1/2] tty: serial: Cleanup the bit shift with macro
Christoph Niedermaier
cniedermaier at dh-electronics.com
Tue Jan 16 07:58:29 PST 2024
In the old definition (1 << 3) wasn't used.
> -#define SER_RS485_RX_DURING_TX (1 << 4)
> -#define SER_RS485_TERMINATE_BUS (1 << 5)
> -#define SER_RS485_ADDRB (1 << 6)
> -#define SER_RS485_ADDR_RECV (1 << 7)
> -#define SER_RS485_ADDR_DEST (1 << 8)
> +#define SER_RS485_ENABLED _BITUL(0)
> +#define SER_RS485_RTS_ON_SEND _BITUL(1)
> +#define SER_RS485_RTS_AFTER_SEND _BITUL(2)
> +#define SER_RS485_RX_DURING_TX _BITUL(3)
Isn't it a break if number 3 isn't skipped here as well?
Regards
Christoph
More information about the linux-arm-kernel
mailing list